【chunkserver & ut】split read-write thread and add localut.sh #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilixiaocui
changed the title
ilixiaocui
force-pushed
the
master
branch
10 times, most recently
from
19f7c1d to
f874e36
Compare
wu-hanqing
reviewed
Sep 16, 2020
coverage/test.py
Outdated
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env python | |||
wu-hanqing
reviewed
Sep 16, 2020
| * @param[in] args: param to excute task | ||
| */ | ||
| template<class F, class... Args> | ||
| bool Push(uint64_t key, CHUNK_OP_TYPE optype, F&& f, Args&&... args) { |
wu-hanqing
reviewed
Sep 16, 2020
| namespace chunkserver { | ||
| namespace concurrent { | ||
|
|
||
| enum ThreadPoolType { |
wu-hanqing
reviewed
Sep 16, 2020
|
|
||
| void InitThreadPool(ThreadPoolType type, int concorrent, int depth); | ||
|
|
||
| inline int Hash(uint64_t key, int concurrent) { |
wu-hanqing
reviewed
Sep 16, 2020
| * @param[in] rconcurrentsizee: num of read threads | ||
| * @param[in] wqueuedephth: depth of read queue in every thread | ||
| */ | ||
| bool Init(int wconcurrentsize, int wqueuedepth, |
wu-hanqing
reviewed
Sep 16, 2020
| wapplyMap_[i]->th = std::move( | ||
| std::thread(&ConcurrentApplyModule::Run, this, type, i)); | ||
| break; | ||
| } |
wu-hanqing
reviewed
Sep 16, 2020
| } | ||
| } | ||
|
|
||
| void ConcurrentApplyModule::Stop() { |
There was a problem hiding this comment.
这里的Stop没有等待TaskQueue中的任务全部执行完成，就直接退出了。
可以不用处理这种场景吗？
或者退出的时候，不会出现队列中还有任务的情况？
There was a problem hiding this comment.
这里stop的时候不需要等任务完成，如果有需求在stop之前需要调用flush。
xu-chaojie
reviewed
Sep 17, 2020
| WRITE | ||
| }; | ||
|
|
||
| class CURVE_CACHELINE_ALIGNMENT ConcurrentApplyModule { |
There was a problem hiding this comment.
读和写的逻辑几乎是完全一样的，这里的代码也是读写各复制了一份，为什么不复用同一个ConcurrentApplyModule，然后读和写是这个类的两个对象，而不是在一个类中实现读和写。读pool和写pool仅仅是线程数不一样而已啊。
There was a problem hiding this comment.
那外面的对象数会增加，要维护的代码会散落在各处
| void ConcurrentApplyModule::Flush() { | ||
| std::atomic<bool>* signal = new (std::nothrow) std::atomic<bool>[wconcurrentsize_]; //NOLINT | ||
| std::mutex* mtx = new (std::nothrow) std::mutex[wconcurrentsize_]; | ||
| std::condition_variable* cv= new (std::nothrow) std::condition_variable[wconcurrentsize_]; //NOLINT |
There was a problem hiding this comment.
这个地方可以改成CountDown优化下，而且在同一个函数中delete了就不需要new，直接临时对象就可以了吧
ilixiaocui
force-pushed
the
master
branch
3 times, most recently
from
c425458 to
0f7b289
Compare
xu-chaojie
approved these changes
Sep 21, 2020
wu-hanqing
approved these changes
Sep 22, 2020
xu-chaojie
approved these changes
Sep 22, 2020
ilixiaocui
force-pushed
the
master
branch
4 times, most recently
from
7275622 to
97dc3ed
Compare
ilixiaocui
force-pushed
the
master
branch
3 times, most recently
from
6a793c6 to
4bac924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: no releated
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List