glog: fix chunkserver exit with core #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hanqing
reviewed
Jul 9, 2021
| }; | ||
|
|
||
| // This protects the following global variables. | ||
| -static Mutex vmodule_lock; |
There was a problem hiding this comment.
there's exists more than one global Mutex, you should check whether the same problem will happen on other global Mutex.
|
recheck |
wu-hanqing
approved these changes
Jul 12, 2021
2 tasks
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
…l-fall-2021 Add project for upgrade/downgrade testing to LFX fall term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
chunkserver will exit with core dump when receive SIGINT
Issue Number: close #425
Problem Summary:
we compile a debug version, and locate abort() as follwing:
abort happens when destruct (static bthread::TimerThread timer_) in curve::common::LeakyBucket.
The lifecycle of static member variable in class is the same as process
bthread::TimerThread destruct with run() exit. run() need log print before exit.
log print need get vmodule_lock, which is a globle static variable
globle static variable and class static member variable are both detruct before process exit. But the order of their destruction is determined by the compiler. If vmodule_lock destruct before bthread::TimerThread, the process will core dump
What is changed and how it works?
What's Changed:
change static Mutex vmodule_lock -> static Mutex* vmodule_lock = new Mutex();
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List