[Fix](common): fix arc cache capacity && add some tests #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
Signed-off-by: zztaki <[email protected]>
|
cicheck |
|
@skypexu PTAL？ |
|
It was fixed in recent commits.
|
|
Yes, you can improve ARC unittest futher if you wish. |
|
A bit unluck for having been fixed recently. Maybe I can try other modules :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2952
Problem Summary: ARCCache cache capacity shoule be
maxCountand there is a lack of ARC related tests here.What is changed and how it works?
What's Changed: adjust ARC cache capacity to
maxCountand add some tests.How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List