curvefs: fix trash will delete file data more than once #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
xu-chaojie
reviewed
Dec 1, 2023
| } | ||
|
|
||
| void TrashImpl::ScanTrash() { | ||
| LockGuard lgScan(scanMutex_); | ||
| // only scan on leader | ||
| if (copysetNode_ == nullptr || !copysetNode_->IsLeaderTerm()) { |
There was a problem hiding this comment.
The following loop also needs to be interrupted when the node is not the leader.
xu-chaojie
reviewed
Dec 1, 2023
|
|
||
| DeleteInodeResponse response; | ||
| DeleteInodeClosure done; | ||
| auto DeleteInodeOp = new copyset::DeleteInodeOperator( |
There was a problem hiding this comment.
Where is this op implemented?
There was a problem hiding this comment.
This operation originally existed and was used to delete the remaining inodes after the creation process failed.
xu-chaojie
reviewed
Dec 1, 2023
curvefs/src/metaserver/trash.cpp
Outdated
| << ", inodeId = " << it->inodeId; | ||
| LOG(INFO) << "Trash delete inode, fsId = " << fsId_ | ||
| << ", partitionId = " << partitionId_ | ||
| << ", inodeId = " << it->inodeId; | ||
| it = temp.erase(it); |
There was a problem hiding this comment.
How to remove trash items on the follower side
There was a problem hiding this comment.
fixed, it will delete in InodeManagger::DeleteInode
Signed-off-by: wanghai01 <[email protected]>
|
cicheck |
wuhongsong
approved these changes
Dec 5, 2023
xu-chaojie
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#2774
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List