Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: curvefs/metaserver ut crash when compiling with release mode #2921

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Ziy1-Tan
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan commented Nov 21, 2023

What problem does this PR solve?

Issue Number: #2916

Problem Summary:

What is changed and how it works?

What's Changed:

Add anonymous namespace wraps class HashIterator.

How it Works:
Classes with the same name (HashItertor) in the same namespace may lead to undefined behavior.

Result:
image

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Ziy1-Tan
Copy link
Contributor Author

cicheck

1 similar comment
@Ziy1-Tan
Copy link
Contributor Author

cicheck

@Ziy1-Tan
Copy link
Contributor Author

cicheck

2 similar comments
@Ziy1-Tan
Copy link
Contributor Author

cicheck

@Ziy1-Tan
Copy link
Contributor Author

cicheck

@SeanHai SeanHai merged commit 1278ff2 into opencurve:master Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants