[fix]tools-v2: panic when show cluster status #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: montaguelhz <[email protected]>
|
@Cyber-SiKu why ci-check not work? |
|
cicheck |
|
cicheck |
|
@Wine93 @Cyber-SiKu PTAL~ |
Cyber-SiKu
approved these changes
Nov 14, 2023
baytan0720
approved these changes
Nov 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #2878
Problem Summary:
When the commands
status clusterrelies on returns an error whileinit, thecmd.Erroris nil, causing the command to panic. Since I don't have the environment, I am not sure if this is the cause of the problem, but it is risky.What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List