Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]tools-v2: add bs query volume clone-recover #2787

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[feat]tools-v2: add bs query volume clone-recover #2787

merged 1 commit into from
Nov 3, 2023

Conversation

baytan0720
Copy link
Member

What problem does this PR solve?

Issue Number: #2584

Problem Summary:

add bs query volume clone-recover

What is changed and how it works?

What's Changed:

How it Works:

Usage:

curve bs query volume clone-recover

Output:

+------+--------------------------------------+--------------------------------------+----------+-------+----------+--------+----------+--------+----------+---------------------+
| USER |                 SRC                  |               TASK ID                | TASKTYPE | FILE  | FILETYPE | ISLAZY | NEXTSTEP | STATUS | PROGRESS |        TIME         |
+------+--------------------------------------+--------------------------------------+----------+-------+----------+--------+----------+--------+----------+---------------------+
| root | a19b5e5e-b306-488f-8e6d-d87282c869cb | d26e27a8-fcbd-4f7a-adf8-53795217cbb0 |  clone   | /root |   file   | false  |   end    |  done  |    1     | 2006-01-02 15:04:05 |
+------+--------------------------------------+--------------------------------------+----------+-------+----------+--------+----------+--------+----------+---------------------+

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@baytan0720
Copy link
Member Author

cicheck

2 similar comments
@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 mentioned this pull request Oct 9, 2023
Closed
Cyber-SiKu
Cyber-SiKu reviewed Oct 10, 2023
View reviewed changes
tools-v2/pkg/cli/command/curvebs/delete/volume/clone/clone.go Outdated
Comment on lines 119 to 123
item["User"].(string),
item["Src"].(string),
item["UUID"].(string),
item["File"].(string),
item["Result"].(string),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined as constant

tools-v2/pkg/cli/command/curvebs/query/volume/clone-recover/clone-recover.go Outdated
@@ -0,0 +1,210 @@
package clone_recover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move down

@Cyber-SiKu
Copy link
Contributor

@baytan0720 pls fix conflicts.

@baytan0720 baytan0720 force-pushed the queryvolume_clone-recover branch 3 times, most recently from 7c14b18 to 0c324f0 Compare November 1, 2023 03:56
@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 closed this Nov 1, 2023
@baytan0720 baytan0720 reopened this Nov 1, 2023
@baytan0720
Copy link
Member Author

cicheck

1 similar comment
@baytan0720
Copy link
Member Author

cicheck

@caoxianfei1 caoxianfei1 merged commit cf3d33f into opencurve:master Nov 3, 2023
5 checks passed
@baytan0720 baytan0720 deleted the queryvolume_clone-recover branch November 3, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyber-SiKu Cyber-SiKu Cyber-SiKu approved these changes

@caoxianfei1 caoxianfei1 caoxianfei1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baytan0720 @Cyber-SiKu @caoxianfei1