[feat]tools-v2: add bs check consistency #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
victorseptember
force-pushed
the
check_file_consistency
branch
from
c016e8b to
dc021a1
Compare
|
cicheck |
1 similar comment
|
cicheck |
Cyber-SiKu
reviewed
Oct 24, 2023
| @@ -0,0 +1,183 @@ | |||
| /* | |||
| * Copyright (c) 2022 NetEase Inc. | |||
| * | |||
There was a problem hiding this comment.
move to pkg/cli/command/curvebs/query/chunkhash?
Comment on lines
91
to
95
| LogicPoolId : &logicalpoolid, | ||
| CopysetId : ©setid, | ||
| ChunkId : &chunkid, | ||
| Offset : &offset, | ||
| Length : &chunksize, |
|
cicheck |
Cyber-SiKu
reviewed
Oct 26, 2023
| @@ -0,0 +1,194 @@ | |||
| /* | |||
| * Copyright (c) 2022 NetEase Inc. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 NetEase Inc. | |
| * Copyright (c) 2023 NetEase Inc. |
victorseptember
force-pushed
the
check_file_consistency
branch
from
5dc1cbe to
e55335d
Compare
|
cicheck |
1 similar comment
|
cicheck |
Signed-off-by: victorseptember <[email protected]>
victorseptember
force-pushed
the
check_file_consistency
branch
from
e55335d to
c007640
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
Cyber-SiKu
approved these changes
Oct 27, 2023
caoxianfei1
approved these changes
Oct 27, 2023
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2351
Problem Summary: Add bs check consistency command.
What is changed and how it works?
What's Changed:
modify tools-v2/README.md
modify tools-v2/internal/error/error.go
modify tools-v2/pkg/cli/command/curvebs/check/check.go
modify tools-v2/pkg/cli/command/curvebs/query/seginfo/seginfo.go
modify tools-v2/pkg/cli/command/curvebs/status/copyset/agent.go
add tools-v2/pkg/cli/command/curvebs/check/consistency/consistency.go
How it Works:
Usage:
Output:
Side effects(Breaking backward compatibility? Performance regression?):
Check List