Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: fix metric may be zero #2730

Closed

Conversation

PerseidMeteor
Copy link

What problem does this PR solve?

Issue Number: #2391

please do not review this pr now

Problem Summary:

What is changed and how it works?

What's Changed: add patch

How it Works: we can cherry-pick some commits, which supports fork new thread without exec, to avoid metric may be zero

Side effects(Breaking backward compatibility? Performance regression?): later...

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

we can cherry-pick some commits, which supports fork new thread without exec, to avoid metric may be zero

Signed-off-by: QiangYu <[email protected]>
@PerseidMeteor PerseidMeteor marked this pull request as draft September 3, 2023 15:17
@h0hmj h0hmj self-requested a review September 5, 2023 03:30
@h0hmj
Copy link
Contributor

h0hmj commented Sep 5, 2023

Advice:

For readable, add your patch to existing brpc.patch is not a good idea.
Add to a new patch is better i think.
just like b71f944

@caoxianfei1
Copy link
Contributor

@PerseidMeteor continue?

1 similar comment
@Cyber-SiKu
Copy link
Contributor

@PerseidMeteor continue?

@wuhongsong
Copy link
Contributor

stale, out to date. if you want to do, can reopen it.

@wuhongsong wuhongsong closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants