-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] curvefs/mds: split large test cases into focused smaller ones #2717
[test] curvefs/mds: split large test cases into focused smaller ones #2717
Conversation
62fc1b9
to
ba838ad
Compare
cicheck |
@wuhongsong |
ba838ad
to
289cf77
Compare
b00196d
to
65666b0
Compare
@wu-hanqing |
cicheck |
2 similar comments
cicheck |
cicheck |
@wu-hanqing |
btw, who should I ask to be the second reviewer? |
I don't have any more questions, except squeeze 4 commits into 1. |
Would you mind reviewing my work? Thanks |
Signed-off-by: Ken Han <[email protected]>
fe2dbd1
to
21b4a8a
Compare
cicheck |
3 similar comments
cicheck |
cicheck |
cicheck |
@SeanHai Could you please review my work when you get a chance? Thank you! |
What problem does this PR solve?
Issue Number: #2505
Problem Summary:
All the test cases in these two files are written into one test suite, and the names of the test cases have no meaningful information. Once the code is modified, it is difficult to change the corresponding unit tests accordingly.
What is changed and how it works?
What's Changed:
How it Works:
Those gigantic test cases were now divided into smaller and more focused ones.
Side effects(Breaking backward compatibility? Performance regression?):
None
Outcome
$ ./bazel-bin/curvefs/test/mds/curvefs_mds_test --gtest_filter=FSManagerTest*
$ ./bazel-bin/curvefs/test/mds/curvefs_mds_test --gtest_filter=MdsServiceTest*
Check List