Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] CurveBS: unify bs and fs apply queue #2641

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[refactor] CurveBS: unify bs and fs apply queue #2641

merged 1 commit into from
Jul 31, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented Jul 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: #1598

Problem Summary:

What is changed and how it works?

What's Changed:
unify bs and fs apply queue.

How it Works:
simply moving Schedule in apply queue to ChunkOpRequest as a utils.

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the bs-refactor-apply-queue branch from d71601f to d1c32af Compare July 27, 2023 11:17
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@wu-hanqing @ilixiaocui PTAL~

@Xinlong-Chen Xinlong-Chen requested a review from wu-hanqing July 27, 2023 11:24
@Xinlong-Chen
Copy link
Contributor Author

cicheck

2 similar comments
@wu-hanqing
Copy link
Contributor

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@SeanHai SeanHai merged commit 7d10847 into opencurve:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanHai SeanHai SeanHai approved these changes

@wu-hanqing wu-hanqing wu-hanqing approved these changes

@ilixiaocui ilixiaocui Awaiting requested review from ilixiaocui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xinlong-Chen @wu-hanqing @SeanHai