-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curvefs/client: make user agent configurable #2501
Conversation
cicheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested that it works?
@@ -10,7 +10,7 @@ s3.sk={{ s3_sk }} | |||
# http = 0, https = 1 | |||
s3.http_scheme={{ s3_http_scheme }} | |||
s3.verify_SSL={{ s3_verify_ssl }} | |||
s3.user_agent_conf={{ s3_user_agent_conf }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ansible is no longer maintained and can not be modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
@@ -265,7 +265,7 @@ nebd_server_response_return_rpc_when_io_error: false | |||
# s3配置默认值 | |||
s3_http_scheme: 0 | |||
s3_verify_ssl: false | |||
s3_user_agent_conf: S3 Browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
cicheck |
Yes. I made sure that
|
cicheck |
Please add the corresponding unit test |
cicheck |
1 similar comment
cicheck |
cicheck |
1 similar comment
cicheck |
cicheck |
curvefs/conf/client.conf |
cicheck |
Get it. I'm trying to figure out why the mds election is timeout but I'm failed. |
@SeanHai help |
cicheck |
2023-06-21 10:06:04.670070 I | [587688dba922b1f6/10.182.2.26:16701]stop watch current leader The curvefs/conf/mds.conf also need add this conf item. If not, it will crash when init s3 adaptor in mds of curvefs. |
cicheck |
1 similar comment
cicheck |
cicheck |
2 similar comments
cicheck |
cicheck |
cicheck |
cicheck |
1 similar comment
cicheck |
cichek |
add more test case @Ziy1-Tan |
cicheck |
add more test case @Ziy1-Tan I have add some test case,lets try it again. |
cicheck |
cicheck |
@Ziy1-Tan will do it later, It's a bit busy these days. |
cicheck |
cicheck |
Signed-off-by: Ziy1-Tan <[email protected]>
cicheck |
What problem does this PR solve?
Issue Number: #2499
Problem Summary:
Let user agent item configurable for users having security reasons
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List