Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help_msg in Makefile #2133

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

linshiyx
Copy link
Contributor

@linshiyx linshiyx commented Dec 4, 2022

What problem does this PR solve?

Issue Number: #2104

Problem Summary:

What is changed and how it works?

What's Changed:
make help will give examples about building and installing.
Don't print usage msg on encountering failure in util/build.sh and util/install.sh.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

…n util/build.sh and util/install.sh.

Signed-off-by: linshiyx <[email protected]>
@ilixiaocui
Copy link
Contributor

Thanks for the contribution @linshiyx. I've tested it and it's great!

@SeanHai
Copy link
Contributor

SeanHai commented Dec 5, 2022

If modified the compile scripts, should not skip ci.

@ilixiaocui ilixiaocui changed the title [skipci]Add help_msg in Makefile Add help_msg in Makefile Dec 5, 2022
@ilixiaocui
Copy link
Contributor

If modified the compile scripts, should not skip ci.

I triggered it.

@ilixiaocui
Copy link
Contributor

image

compile ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants