Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compile] update the braft to vesion v1.1.2 #2091

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[compile] update the braft to vesion v1.1.2 #2091

merged 1 commit into from
Nov 28, 2022

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Nov 20, 2022

Signed-off-by: tangwz [email protected]

What problem does this PR solve?

Issue Number: #2071

Problem Summary:

Update braft to latest version v1.1.2

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@tangwz tangwz changed the title [compile] update the braft to vesion v1.1.2 [WIP][compile] update the braft to vesion v1.1.2 Nov 20, 2022
@tangwz
Copy link
Contributor Author

tangwz commented Nov 21, 2022

@ilixiaocui @wu-hanqing CI use the repo https://gitee.com/baidu/braft, but this repo hasn't sync the newest version from https://github.com/baidu/braft/releases/tag/v1.1.2.So do we use version v1.1.1?

@wu-hanqing
Copy link
Contributor

@ilixiaocui @wu-hanqing CI use the repo https://gitee.com/baidu/braft, but this repo hasn't sync the newest version from https://github.com/baidu/braft/releases/tag/v1.1.2.So do we use version v1.1.1?

@zhanghuidinah Please clone braft under https://gitee.com/NetEase_Curve and ensure tag v1.1.2 exists.

@zhanghuidinah
Copy link
Member

https://gitee.com/NetEase_Curve/braft/tree/v1.1.2/ @tangwz PTAL

@tangwz
Copy link
Contributor Author

tangwz commented Nov 22, 2022 •
edited
Loading

https://gitee.com/NetEase_Curve/braft/tree/v1.1.2/ @tangwz PTAL

@zhanghuidinah It's a private repo?I have no permission.

@wu-hanqing
Copy link
Contributor

https://gitee.com/NetEase_Curve/braft/tree/v1.1.2/ @tangwz PTAL

@zhanghuidinah It's a private repo?I have no permission.

Sorry, it's a mistake. It's a public repository now.

@cw123
Copy link
Contributor

cw123 commented Nov 23, 2022

recheck

1 similar comment
@cw123
Copy link
Contributor

cw123 commented Nov 24, 2022

recheck

@ilixiaocui
Copy link
Contributor

ilixiaocui commented Nov 24, 2022 •
edited
Loading

Please synthesize one commit to submit.
image

@tangwz tangwz changed the title [WIP][compile] update the braft to vesion v1.1.2 [compile] update the braft to vesion v1.1.2 Nov 24, 2022
@tangwz tangwz force-pushed the update_lastest_braft branch from fc57227 to a9ad349 Compare November 24, 2022 14:39
@tangwz
Copy link
Contributor Author

tangwz commented Nov 25, 2022

@ilixiaocui PTAL

@ilixiaocui
Copy link
Contributor

LGTM！

@ilixiaocui ilixiaocui merged commit 5b06eb3 into opencurve:master Nov 28, 2022
@ilixiaocui ilixiaocui mentioned this pull request Nov 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilixiaocui ilixiaocui ilixiaocui approved these changes

@wu-hanqing wu-hanqing wu-hanqing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangwz @wu-hanqing @zhanghuidinah @cw123 @ilixiaocui