add async in read from s3 #2080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
wuhongsong
reviewed
Nov 22, 2022
| @@ -532,14 +532,35 @@ int FileCacheManager::ReadFromS3(const std::vector<S3ReadRequest> &requests, | |||
| uint64_t start = butil::cpuwide_time_us(); | |||
| if (async) { | |||
There was a problem hiding this comment.
if async is enable, you can set（bool async = true;)
Signed-off-by: YLShi <[email protected]>
YLShiJustFly
force-pushed
the
add_async_for_readfroms3
branch
from
d9db62a to
75433a3
Compare
|
recheck |
cw123
reviewed
Nov 29, 2022
|
recheck |
1 similar comment
|
recheck |
|
cc@YLShiJustFly This pr has been opened for a long time, and the review comments have not been replied. Please resubmit the pr if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YLShi [email protected]
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List