Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiyaoliang qos for fuse #2069

Closed

Conversation

YLShiJustFly
Copy link

@YLShiJustFly YLShiJustFly commented Nov 14, 2022

What problem does this PR solve?

Issue Number: #2048

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

void FuseS3Client::InitQosParam() {
ReadWriteThrottleParams params;
params.iopsWrite = ThrottleParams(FLAGS_avgFlushIops, 0, 0);
params.bpsWrite = ThrottleParams(FLAGS_avgFlushBytes, FLAGS_burstFlushBytes,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configurable is better

@YLShiJustFly YLShiJustFly force-pushed the shiyaoliang_qos_for_fuse branch from 1ddf4fe to 1f3dbd6 Compare November 29, 2022 00:22
Copy link
Contributor

@cw123 cw123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some unit test

cpplint is failed. cpplint../curvefs/src/client/fuse_s3_client.h

Stacktrace
122: "private:" should be preceded by a blank line [whitespace/blank_line] [3]

@cw123
Copy link
Contributor

cw123 commented Nov 29, 2022

recheck

@wuhongsong
Copy link
Contributor

cpplint and pjdtest(code compile) have some problem, please revise it, thanks.

@ilixiaocui
Copy link
Contributor

cc @YLShiJustFly This pr has been opened for a long time, and the review comments have not been replied. Please resubmit the pr if necessary.

@ilixiaocui ilixiaocui closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants