-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shiyaoliang qos for fuse #2069
Shiyaoliang qos for fuse #2069
Conversation
void FuseS3Client::InitQosParam() { | ||
ReadWriteThrottleParams params; | ||
params.iopsWrite = ThrottleParams(FLAGS_avgFlushIops, 0, 0); | ||
params.bpsWrite = ThrottleParams(FLAGS_avgFlushBytes, FLAGS_burstFlushBytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configurable is better
55dd2d9
to
1ddf4fe
Compare
1ddf4fe
to
1f3dbd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some unit test
cpplint is failed. cpplint../curvefs/src/client/fuse_s3_client.h
Stacktrace
122: "private:" should be preceded by a blank line [whitespace/blank_line] [3]
recheck |
cpplint and pjdtest(code compile) have some problem, please revise it, thanks. |
cc @YLShiJustFly This pr has been opened for a long time, and the review comments have not been replied. Please resubmit the pr if necessary. |
What problem does this PR solve?
Issue Number: #2048
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List