curvefs/client: Clarify val #2059
Conversation
|
good job @shentupenghui |
Signed-off-by: 申屠鹏会 <[email protected]>
curvefs/src/client/common/config.cpp
Outdated
| &volumeOpt->allocatorOption.blockGroupOption.allocateOnce); | ||
|
|
||
| if (volumeOpt->allocatorOption.type == "bitmap") { | ||
| conf->GetValueFatalIfFail( | ||
| "volume.bitmapallocator.size_per_bit", | ||
| "volume.bitmapAllocator.size_per_bit", | ||
| &volumeOpt->allocatorOption.bitmapAllocatorOption.sizePerBit); | ||
| conf->GetValueFatalIfFail( | ||
| "volume.bitmapallocator.small_alloc_proportion", |
There was a problem hiding this comment.
conf->GetValueFatalIfFail(
"volume.bitmapallocator.small_alloc_proportion",
There was a problem hiding this comment.
im sry for missing one unchanged
There was a problem hiding this comment.
conf->GetValueFatalIfFail( "volume.bitmapallocator.small_alloc_proportion",
done
There was a problem hiding this comment.
good job, lets us wait the ci finished
There was a problem hiding this comment.
CI still running, is there some failure occured?
There was a problem hiding this comment.
CI still running, is there some failure occured?
http://59.111.91.248:8080/job/opencurve_multijob/6935/
as you can see, there is running the failover test.
There was a problem hiding this comment.
the failover test log shows:
------------------------------------------------------------------------------
test loop mount umount | FAIL |
mount/umount error
------------------------------------------------------------------------------
Signed-off-by: 申屠鹏会 <[email protected]>
wuhongsong
requested review from
Cyber-SiKu and
ilixiaocui
and removed request for
ilixiaocui
|
recheck |
Signed-off-by: 申屠鹏会 <[email protected]>
|
@Cyber-SiKu all done in the latest commit |
LGTM! |
What problem does this PR solve?
Issue Number: #2049
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
also replace all related files
Side effects(Breaking backward compatibility? Performance regression?):
No
Check List