curvefs/client: fix warmup bug(#1841) #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xu-chaojie
reviewed
Aug 25, 2022
| @@ -304,7 +304,8 @@ void FuseS3Client::WarmUpAllObjs( | |||
| context->cb = cb; | |||
| s3Adaptor_->GetS3Client()->DownloadAsync(context); | |||
| } | |||
| cond.Wait(); | |||
| if (pendingReq.load()) | |||
There was a problem hiding this comment.
It seems useless, please explain why？
There was a problem hiding this comment.
if all objs has cached, then the function will block
xu-chaojie
approved these changes
Aug 25, 2022
|
recheck |
if all objs has cached, then the function will block signed-off-by: hzwuhongsong [email protected]
wuhongsong
force-pushed
the
warmup_fixs
branch
from
bb9279d to
573d4da
Compare
|
recheck |
4 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
ilixiaocui
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if all objs has cached, then the function will block
signed-off-by: hzwuhongsong [email protected]
What problem does this PR solve?
Issue Number: #1841
Issue Number: #1833