add s3.useVirtualAddressing config #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspirer
reviewed
Apr 8, 2022
| @@ -132,6 +132,8 @@ void InitS3AdaptorOptionExceptS3InfoOption(Configuration* conf, | |||
| &s3Opt->bpsReadMB)); | |||
| LOG_IF(FATAL, !conf->GetUInt64Value("s3.throttle.bpsWriteMB", | |||
| &s3Opt->bpsWriteMB)); | |||
| LOG_IF(FATAL, !conf->GetBoolValue("s3.useVirtualAddressing", | |||
| &s3Opt->useVirtualAddressing)); | |||
There was a problem hiding this comment.
also need add this config in func InitS3AdaptorOption?
There was a problem hiding this comment.
InitS3AdaptorOption will reuse InitS3AdaptorOptionExceptS3InfoOption
aspirer
approved these changes
Apr 12, 2022
|
tests passed: |
wu-hanqing
approved these changes
Apr 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
We do not support virtual host.
What is changed and how it works?
What's Changed:
Support both virtual host and path style
How it Works:
Add a config, init client with config
Side effects(Breaking backward compatibility? Performance regression?):
Check List