curvefs/tool: fix copyset health check error #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
SeanHai
reviewed
Jan 24, 2022
| for (auto const& i : key2Info) { | ||
| if (copyset::checkCopysetHelthy(i.second, key2Status[i.first]) != | ||
| copyset::CheckResult::kHealthy) { | ||
| isHealth = false; |
There was a problem hiding this comment.
The unhealthy copysets can be recorded and show the detail if needed.
There was a problem hiding this comment.
The unhealthy copysets can be recorded and show the detail if needed.
now is show all copyset, will add this feature.
wu-hanqing
reviewed
Jan 24, 2022
| std::vector<curvefs::metaserver::copyset::CopysetStatusResponse>> | ||
| key2Status; | ||
| copyset::CopysetInfo2CopysetStatus(*response.get(), &key2Status); | ||
| copyInfoListTool_->RunCommand(); |
There was a problem hiding this comment.
why drop the return value?
There was a problem hiding this comment.
why drop the return value?
fix
| std::map<uint64_t, | ||
| std::vector<curvefs::metaserver::copyset::CopysetStatusResponse>> | ||
| key2Status; | ||
| copyset::CopysetInfo2CopysetStatus(*response.get(), &key2Status); |
There was a problem hiding this comment.
ditto, you didn't handle return value
|
|
||
| copyset::Response2CopysetInfo(*response.get(), &key2Info); | ||
| copyset::Response2CopysetInfo(*response.get(), &key2Info); |
when get all coysetinfo (in curvefs_copyset_status) has error, tools would not to check copyset status, so get health instaed of unhealthy
Cyber-SiKu
force-pushed
the
curvefs-tool/fix-bug-master
branch
from
ddc8e9b to
1c45b4c
Compare
|
recheck |
1 similar comment
|
recheck |
SeanHai
approved these changes
Feb 14, 2022
wu-hanqing
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1022 #1026
Problem Summary:
when get all coysetinfo (in curvefs_copyset_status) has error,
tools would not to check copyset status,
so get health instaed of unhealthy
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List