Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve/toos-v2]: add list client #2037

Closed
Cyber-SiKu opened this issue Nov 4, 2022 · 1 comment
Closed

[curve/toos-v2]: add list client #2037

Cyber-SiKu opened this issue Nov 4, 2022 · 1 comment
Labels
curvebs good first issue Good for newcomers tools Tool improvements

Comments

@Cyber-SiKu
Copy link
Contributor

Cyber-SiKu commented Nov 4, 2022

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support list client command in curve tool

  • The implementation of the old tool is here:
    int StatusTool::ClientListCmd() {
    std::vector<std::string> clientAddrs;
    int res = mdsClient_->ListClient(&clientAddrs, FLAGS_listClientInRepo);
    if (res != 0) {
    std::cout << "ListClient from mds fail!" << std::endl;
    return -1;
    }
    for (const auto& addr : clientAddrs) {
    std::cout << addr << std::endl;
    }
    return 0;
    }
  • The old command input and out put:
  curve_ops_tool client-list 
  output:
***.***.***.***:****

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

Describe the solution you'd like (描述你期望的解决方法)

Add subcommand clinet to curve bs list.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@zhanghuidinah
Copy link
Member

/assign @tsonglew

tsonglew added a commit to tsonglew/curve that referenced this issue Nov 15, 2022
tsonglew added a commit to tsonglew/curve that referenced this issue Nov 15, 2022
tsonglew added a commit to tsonglew/curve that referenced this issue Nov 16, 2022
tsonglew added a commit to tsonglew/curve that referenced this issue Nov 16, 2022
tsonglew added a commit to tsonglew/curve that referenced this issue Nov 17, 2022
cw123 pushed a commit that referenced this issue Nov 17, 2022
Cyber-SiKu pushed a commit to Cyber-SiKu/curve that referenced this issue Jul 20, 2023
Cyber-SiKu pushed a commit that referenced this issue Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curvebs good first issue Good for newcomers tools Tool improvements
Projects
None yet
Development

No branches or pull requests

3 participants