Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curvefs/metaserver: cannot get a full copy of one inode #1304

Closed
h0hmj opened this issue Apr 20, 2022 · 0 comments
Closed

curvefs/metaserver: cannot get a full copy of one inode #1304

h0hmj opened this issue Apr 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working high high priority need test Completion of development, requires QA verification

Comments

@h0hmj
Copy link
Contributor

h0hmj commented Apr 20, 2022

Describe the bug (描述bug)

if we want to get a copy of a inode,
we need GetInode and PaddingInodeS3ChunkInfo two rpc from InodeManager.

rpc1 -> GetInode: len=1 (s3chunkinfolist: slice 1)
changes -> some write, s3chunkinfolist: silce 1, slice 2
rpc2 -> PaddingInodeS3ChunkInfo: s3chunkinfolist: slice 1, slice 2

so we get inode, len=1 and s3chunkinfolist: slice1, slice2, which is wrong

if our s3compact threshold is 1, it will be compact to len=1, s3chunkinfolist: slice1
slice2 is regarded as useless data maybe from truncate smalle, and will be deleted.

inode will be updated to len=2, s3chunkinfolist: slice 1; we lose our data.

So we need a method to get a full copy of a inode when needed.

To Reproduce (复现方法)

Expected behavior (期望行为)

Versions (各种版本)
commit: c783e83

Additional context/screenshots (更多上下文/截图)

@h0hmj h0hmj added the bug Something isn't working label Apr 20, 2022
@wuhongsong wuhongsong added the high high priority label May 9, 2022
Wine93 added a commit that referenced this issue May 14, 2022
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (#1304) (#1308)
@Wine93 Wine93 added the need test Completion of development, requires QA verification label May 14, 2022
fansehep pushed a commit to fansehep/curve that referenced this issue May 25, 2022
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
fansehep pushed a commit to fansehep/curve that referenced this issue May 25, 2022
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
fansehep pushed a commit to fansehep/curve that referenced this issue May 28, 2022
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
YunhuiChen pushed a commit that referenced this issue May 30, 2022
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (#1304) (#1308)
@Wine93 Wine93 closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high high priority need test Completion of development, requires QA verification
Projects
None yet
Development

No branches or pull requests

3 participants