Skip to content

Commit

Permalink
curvefs/client:the implementation of readdirplus is problematic
Browse files Browse the repository at this point in the history
The current implementation of this interface is problematic, resulting in inconsistent metadata

signed-off-by: hzwuhongsong [email protected]
  • Loading branch information
wuhongsong committed Dec 8, 2022
1 parent 76814b9 commit 4213163
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions curvefs/src/client/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
*/

#include <unordered_map>
#include <string>
#include "curvefs/src/client/curve_fuse_op.h"
#include "curvefs/src/client/fuse_common.h"

Expand All @@ -48,11 +47,13 @@ static const struct fuse_lowlevel_ops curve_ll_oper = {
release : FuseOpRelease,
fsync : FuseOpFsync,
opendir : FuseOpOpenDir,
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
readdir : 0,
#else
// TODO(wuhongsong): readdirplus is problematic,
// resulting in inconsistent metadata
// #if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
// readdir : 0,
// #else
readdir : FuseOpReadDir,
#endif
// #endif
releasedir : FuseOpReleaseDir,
fsyncdir : 0,
statfs : FuseOpStatFs,
Expand All @@ -76,9 +77,11 @@ static const struct fuse_lowlevel_ops curve_ll_oper = {
flock : 0,
fallocate : 0,
#endif
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
readdirplus : FuseOpReadDirPlus,
#endif
// TODO(wuhongsong): The current implementation is problematic,
// resulting in inconsistent metadata
// #if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
readdirplus : 0,
// #endif
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 4)
copy_file_range : 0,
#endif
Expand Down

0 comments on commit 4213163

Please sign in to comment.