Feat: delete the sync deployment after deploy complete

pkg/controllers/client.go

@@ -5,15 +5,17 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/opencurve/curve-operator/pkg/daemon"
-	"github.com/opencurve/curve-operator/pkg/k8sutil"
 	"github.com/pkg/errors"
 	apps "k8s.io/api/apps/v1"
 	v1 "k8s.io/api/core/v1"
 	kerrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/tools/remotecommand"
+	"k8s.io/client-go/util/retry"
+
+	"github.com/opencurve/curve-operator/pkg/daemon"
+	"github.com/opencurve/curve-operator/pkg/k8sutil"
 )
 
 const (
@@ -86,6 +88,7 @@ func createSyncDeployment(c *daemon.Cluster) error {
 			return err
 		}
 	}
+
 	// update condition type and phase etc.
 	return nil
 }
@@ -154,3 +157,22 @@ func getReadConfigJobLabel(c *daemon.Cluster) map[string]string {
 	labels["curve"] = c.Kind
 	return labels
 }
+
+// deleteSyncConfigDeployment delete the SyncConfigDeployment after the cluster is deployed.
+func deleteSyncConfigDeployment(c *daemon.Cluster, syncConfigDeployment string) error {
+	err := retry.OnError(retry.DefaultRetry, func(err error) bool {
+		// retrying for any error that occurs
+		return true
+	}, func() error {
+		return c.Context.Clientset.AppsV1().Deployments(c.Namespace).Delete(syncConfigDeployment, &metav1.DeleteOptions{})
+	})
+
+	if err != nil {
+		return errors.Wrapf(err, "failed to delete deployment %s after the %s has been deployed",
+			SyncConfigDeployment, c.Kind)
+	}
+
+	logger.Infof("the %s has been deployed and the deployment %s has been deleted", c.Kind, SyncConfigDeployment)
+
+	return nil
+}

pkg/controllers/cluster.go

@@ -115,6 +115,12 @@ func reconcileCurveDaemons(c *daemon.Cluster) error {
 		return err
 	}
 
+	// clean up the cluster install environment
+	err = cleanClusterInstallEnv(c)
+	if err != nil {
+		return err
+	}
+
 	return nil
 }
 
@@ -147,5 +153,16 @@ func reconcileCurveFSDaemons(c *daemon.Cluster) error {
 		return err
 	}
 
+	// clean up the cluster install environment
+	err = cleanClusterInstallEnv(c)
+	if err != nil {
+		return err
+	}
+
 	return nil
 }
+
+// cleanClusterInstallEnv clean up the cluster install environment
+func cleanClusterInstallEnv(c *daemon.Cluster) error {
+	return deleteSyncConfigDeployment(c, SyncConfigDeployment)
+}