Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-v2): form validation #8120

Merged
merged 15 commits into from
Dec 4, 2024
Merged

feat(events-v2): form validation #8120

merged 15 commits into from
Dec 4, 2024

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Dec 2, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis marked this pull request as ready for review December 3, 2024 15:45
@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 3, 2024
@github-actions github-actions bot temporarily deployed to featevents-v2-form-validation December 3, 2024 15:45 Inactive
@naftis naftis force-pushed the feat/events-v2-form-validation branch from 9edad33 to 576ad47 Compare December 3, 2024 15:57
@naftis naftis temporarily deployed to featevents-v2-form-validation December 3, 2024 15:57 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to featevents-v2-form-validation December 3, 2024 16:02 — with GitHub Actions Inactive
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://featevents-v2-form-validation.opencrvs.dev

@naftis
feat: continue validations
2376ce5 
note! I removed the <Controller>'d input: we otherwise would need to forwardRef to all the Registered Fields. Let's see if we need to revert this later but hooks should work well for now.
@naftis naftis temporarily deployed to featevents-v2-form-validation December 3, 2024 16:57 — with GitHub Actions Inactive
@rikukissa rikukissa temporarily deployed to featevents-v2-form-validation December 4, 2024 07:50 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to featevents-v2-form-validation December 4, 2024 11:08 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to featevents-v2-form-validation December 4, 2024 11:18 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to featevents-v2-form-validation December 4, 2024 11:30 — with GitHub Actions Inactive
@naftis naftis enabled auto-merge (squash) December 4, 2024 11:56
@rikukissa rikukissa deployed to featevents-v2-form-validation December 4, 2024 15:40 — with GitHub Actions Active
@naftis naftis merged commit 7a75d55 into develop Dec 4, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makelicious makelicious makelicious approved these changes

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naftis @ocrvs-bot @makelicious @rikukissa