Events V2: implement indexing for events #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
added
the
🚀 Ready to deploy
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
reviewed
Nov 27, 2024
| @@ -62,18 +64,23 @@ export const appRouter = router({ | |||
| return getEventById(input) | |||
| }), | |||
| actions: router({ | |||
| notify: publicProcedure.input(ActionNotifyInput).mutation((options) => { | |||
| notify: publicProcedure.input(NotifyActionInput).mutation((options) => { | |||
There was a problem hiding this comment.
why don't we need .omit({ type }) here?
naftis
reviewed
Nov 27, 2024
naftis
reviewed
Nov 27, 2024
|
|
||
| import { z } from 'zod' | ||
|
|
||
| const Status = z.enum([ |
There was a problem hiding this comment.
the actions were defined as a const object, this would align better with Zod so should we use this method there as well. Can the specific statuses be accessed with Status.enum.CREATED or sth?
naftis
reviewed
Nov 27, 2024
naftis
reviewed
Nov 27, 2024
Comment on lines
+72
to
+81
| id: { type: 'keyword' }, | ||
| type: { type: 'keyword' }, | ||
| status: { type: 'keyword' }, | ||
| createdAt: { type: 'date' }, | ||
| createdBy: { type: 'keyword' }, | ||
| createdAtLocation: { type: 'keyword' }, | ||
| modifiedAt: { type: 'date' }, | ||
| assignedTo: { type: 'keyword' }, | ||
| updatedBy: { type: 'keyword' }, | ||
| data: { type: 'object', enabled: true } |
There was a problem hiding this comment.
wonder if this could be satisfies EventDocument'ed in someway
|
Your environment is deployed to https://ocrvs-7875.opencrvs.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.