Fix: advanced search pills #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
jamil314
added
the
🚀 Ready to deploy
github-actions
bot
temporarily deployed
to
fix-advanced-search-pills
jamil314
temporarily deployed
to
fix-advanced-search-pills
GitHub Actions
Inactive
|
Your environment is deployed to https://fix-advanced-search-pills.opencrvs.dev |
jamil314
temporarily deployed
to
fix-advanced-search-pills
GitHub Actions
Inactive
Zangetsu101
requested changes
Nov 25, 2024
| @@ -165,7 +165,7 @@ export const transformAdvancedSearchLocalStateToStoreData = ( | |||
| ) { | |||
| transformedStoreState.registrationStatuses = | |||
| localState.registrationStatuses === RegStatus.Registered | |||
| ? [RegStatus.Registered, RegStatus.Certified, RegStatus.Issued] | |||
| ? [RegStatus.Registered, RegStatus.Issued] | |||
There was a problem hiding this comment.
@jamil314 let's keep this as they were previously as I remember there was a requirement that selecting "Registered" in the status dropdown should return all the records that have been registered, which includes both "Certified" & "Issued" ones
jamil314
temporarily deployed
to
fix-advanced-search-pills
GitHub Actions
Inactive
Zangetsu101
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.