Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events V2: Events service #8005

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Events V2: Events service #8005

merged 3 commits into from
Nov 19, 2024

Conversation

rikukissa
Copy link
Member

No description provided.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Collaborator

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍


test('stored events can be modified', async () => {
const originalEvent = await client.event.create({
transactionId: '1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could start early by having a seeder mechanism from the beginning

Maybe something like this:

const eventTestSeeder = () => {
  // there are more sophisticated options, of course.
  let i = 0
  const createEventTransaction = (event: { event?: Event }) => {
    return {
      transactionId: i++,
      event: event ?? { type: 'birth' }
    }
  }

  return {
    createEventTransaction
  }
}

@rikukissa rikukissa merged commit 8e6b600 into develop Nov 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants