Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add unlink/rmdir. Fixes #7 #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikebryant
Copy link

Here's an initial implementation of unlink/rmdir.
Seems to work locally (I've tested deleting namespaces, individual pods, and all pods in a namespace), but I haven't started writing tests etc yet.

rm -rf ends up being very slow, as it ends up populating the cache of everything underneath it, and it starts going a big wonky when it tries to delete nodes etc..
rmdir is nice and quick, and works as expected

@bspaans
Copy link
Contributor

bspaans commented Jul 27, 2016

Nice one! Unfortunately I don't have time this week to do a proper review, but will pick it up early next week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants