Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add development instructions #3

Merged
merged 2 commits into from
May 31, 2016
Merged

add development instructions #3

merged 2 commits into from
May 31, 2016

Conversation

afeld
Copy link
Member

@afeld afeld commented May 27, 2016

Fixes #2.

/cc moovweb/gokogiri#95

@jcscottiii
Copy link
Member

This project uses the vendor folder only supported by Go1.6+ by default (1.5 if you use some env variables). But let's just support 1.6

Your README needs to tell people to use 1.6

@afeld
Copy link
Member Author

afeld commented May 31, 2016

I happen to be using the vendor/ folder, but it would still work in older versions of Go with the old dependency structure, right?

@jcscottiii
Copy link
Member

it would work if the person with Go version <1.6 runs go get personally on their computer. But otherwise, all the old toolchains only look in certain places for dependencies. Go1.6 adds the vendor folder for a new location.

@afeld
Copy link
Member Author

afeld commented May 31, 2016

D'oh, I get it now. Forgot that we were checking the dependencies into the repository. Updated!

@jcscottiii jcscottiii merged commit bba0124 into master May 31, 2016
@jcscottiii jcscottiii deleted the dev-instructions branch May 31, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants