Misc nitpicks #206
Merged
Misc nitpicks #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kolyshkin
commented
Aug 29, 2023
kolyshkin
commented
- Fix Makefile.
- Add TODO to remove min/max.
- Add codespell to CI.
So one can run e.g. "make GO=go1.21.0 test". Signed-off-by: Kir Kolyshkin <[email protected]>
Go 1.21 has built-in min and max, so there is no need to define our own (OTOH it's not a problem to have it). I tried to move min/max to a separate file having "//go:build !go1.21" build constraint, but go1.21.0 complains: > max requires go1.21 or later (-lang was set to go1.19; check go.mod) > min requires go1.21 or later (-lang was set to go1.19; check go.mod) I have no idea how to work around that; so let's just add a TODO item to remove min/max when it's time. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
requested review from
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
thaJeztah
reviewed
Aug 29, 2023
| @@ -25,7 +25,7 @@ build-cross: | |||
|
|
|||
| .PHONY: test | |||
| test: | |||
| go test -timeout 3m ${TESTFLAGS} -v ./... | |||
| $(GO) test -timeout 3m ${TESTFLAGS} -v ./... | |||
There was a problem hiding this comment.
I'm not sure if overriding versions still work with their recent changes to automatically install versions and downgrade language versions based on go.mod 🤔
thaJeztah
reviewed
Aug 31, 2023
Comment on lines
+42
to
+51
| codespell: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: install deps | ||
| # Version of codespell bundled with Ubuntu is way old, so use pip. | ||
| run: pip install codespell | ||
| - name: run codespell | ||
| run: codespell | ||
|
|
There was a problem hiding this comment.
Oh! I wanted to check if there was an action for this; and then I stumbled on a PR that was adding it; so: yes, there's an action for this; https://github.com/codespell-project/actions-codespell so we may as well use that?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.