Add initial version of runtimetest command: #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase. (On my review list). |
zenlint
force-pushed
the
initruntimetestCmd
branch
5 times, most recently
from
acb0c2e
to
5290838
Compare
|
@mrunalp Any review comments plz let me know, thx. |
zenlint
force-pushed
the
initruntimetestCmd
branch
from
5c6d742
to
4a6f739
Compare
zenlint
force-pushed
the
initruntimetestCmd
branch
from
4a6f739
to
acc1da1
Compare
Signed-off-by: linzhinan(zen Lin) <[email protected]>
Signed-off-by: linzhinan(zen Lin) <[email protected]>
|
@liangchenye I have already reabased the PR. |
| count := 0 | ||
|
|
||
| for { | ||
|
|
There was a problem hiding this comment.
unnecessary empty line here.
|
@mrunalp Thanks very much, I have reviewed it myself and also fixed the format problems you pointed out. |
Signed-off-by: linzhinan(zen Lin) <[email protected]>
zenlint
force-pushed
the
initruntimetestCmd
branch
from
4bb50c9
to
5e909b5
Compare
Signed-off-by: linzhinan(zen Lin) <[email protected]>
Signed-off-by: linzhinan(zen Lin) <[email protected]>
Signed-off-by: linzhinan(zen Lin) <[email protected]>
|
Looks good, I have three suggestions:
|
wking
added a commit
to wking/ocitools-v2
that referenced
this pull request
Feb 10, 2017
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY, ...), 2015-12-02, opencontainers#9). Signed-off-by: W. Trevor King <[email protected]>
Merged
|
Close now that #336 has landed? |
|
as #336 landed, close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial version of runtimetest command:
add unit and config for managing cases;
replace runtime_test.sh to golang realization;
Signed-off-by: zen Lin(Lin Zhinan) [email protected]