validation/util/container: Use --bundle (and stop requiring BundleDir) #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'signed-off-by' required @wking |
wking
force-pushed
the
create-bundle-argument
branch
from
cf5cd7f
to
196855e
Compare
|
@wking I think you should resubmit the commit. |
|
Closing and reopening to kick Travis. |
wking
commented
Jan 18, 2018
validation/util/container.go
Outdated
| @@ -30,19 +30,26 @@ func NewRuntime(runtimeCommand string, bundleDir string) (Runtime, error) { | |||
| var err error | |||
| r.RuntimeCommand, err = exec.LookPath(runtimeCommand) | |||
| if err != nil { | |||
| return Runtime{}, err | |||
| return Runtime{}, clierror.NewError(clierror.Executable, err, "1.0.0") | |||
There was a problem hiding this comment.
Oops,I didn't mean to include clierror stuff in this PR.
Address a previous TODO. And now that we are using --bundle, we no longer need to set cmd.Dir. The TODO mentions a lack of runc support, but runc supports --bundle since opencontainers/runc@3fe7d7f3 (Add create and start command for container lifecycle, 2016-05-13, opencontainers/runc#827). Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
create-bundle-argument
branch
from
196855e
to
b5a43d1
Compare
|
LGTM |
Merged
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a previous TODO. And now that we are using
--bundle, we no longer need to setcmd.Dir. The TODO mentions a lack of runc support, but runc supports--bundlesince opencontainers/runc@3fe7d7f3 (opencontainers/runc#827).