fix rootfs-propagation #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Sep 25, 2017
| @@ -130,11 +130,9 @@ __oci-runtime-tool_complete_compliance_level() { | |||
| __oci-runtime-tool_complete_propagations() { | |||
| COMPREPLY=( $( compgen -W " | |||
| private | |||
| rprivate | |||
| rshared | |||
| rslave | |||
There was a problem hiding this comment.
This catches up with the 1.0 spec, but we may want to see how opencontainers/runtime-spec#923 plays out before removing them. Or we can remove them now and restore them later if the the r* forms get added to the spec.
There was a problem hiding this comment.
I think we can remove them now, and make changes when spec changes.
There was a problem hiding this comment.
+1, we can remove them now.
|
LGTM |
added 2 commits
September 29, 2017 14:35
Signed-off-by: zhouhao <[email protected]>
Signed-off-by: zhouhao <[email protected]>
zhouhao3
force-pushed
the
fix-rootfs-propagation
branch
from
0ba2765
to
6dabb9b
Compare
|
I have modified a similar situation in |
|
LGTM |
|
@liangchenye @hqhq PTAL |
liangchenye
reviewed
Oct 18, 2017
| @@ -130,11 +130,9 @@ __oci-runtime-tool_complete_compliance_level() { | |||
| __oci-runtime-tool_complete_propagations() { | |||
| COMPREPLY=( $( compgen -W " | |||
| private | |||
| rprivate | |||
| rshared | |||
| rslave | |||
There was a problem hiding this comment.
+1, we can remove them now.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]