add pullapprove.yml as PullApprove enabled #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ma Shimiao <[email protected]>
|
076e5dc looks good to me (except for the team, it matches the
in-flight opencontainers/project-template#21).
I'd rather be addressing this sort of thing by landing the
project-template PRs (possibly after OCI-wide maintainer votes) and
then merging project-template's master into this repository. But if
updating project-template is too difficult, cherry-picks like this to
pull content over a piece at a time will work.
|
|
LGTM |
|
I don't know if branch-protection is setup for this repo, but if it is |
|
LGTM |
|
@caniszczyk pullapprove is asking for your review for this to be merged. Not sure why. |
|
@caniszczyk PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]