update README.md to keep consistent with generate.go and MAKEFILE #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang Qilin <[email protected]>
|
Thanks! LGTM. |
mrunalp
pushed a commit
that referenced
this pull request
Jan 20, 2016
update README.md to keep consistent with generate.go and MAKEFILE
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Nov 17, 2016
…ing-guidelines Add contributing and maintainer guidelines.
wking
added a commit
to wking/ocitools-v2
that referenced
this pull request
Nov 17, 2016
And excessive trailing newlines. These came in with fcc7f42 (Add contributing and maintainer guidelines, 2016-05-03, opencontainers#1), because we don't have Git validation yet [1]. [1]: opencontainers/project-template#2 Signed-off-by: W. Trevor King <[email protected]>
wking
added a commit
to wking/ocitools-v2
that referenced
this pull request
Nov 17, 2016
The sign-off requirement catches us up with fcc7f42 (Add contributing and maintainer guidelines, 2016-05-03, opencontainers#1). The author ignore catches us up with c82a2e7 (MAINTAINERS: disallow self-LGTMs, 2016-05-27, opencontainers#13). The push reset catches us up with opencontainers/runtime-spec@aa9f3a26 (Add PullApprove checks, 2016-05-26, opencontainers/runtime-spec#458), opencontainers/image-spec@95a46754d (Add PullApprove support to enforce review, 2016-06-01, opencontainers/image-spec#101) and opencontainers/runc@e2fd7c11 (Add PullApprove support, 2016-05-26, opencontainers/runc#847). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current generate.go support the generation of more
specsitems than listed in README , and in MAKEFILE we have the install function , this PR keep README consistent with generate.go and MAKEFILESigned-off-by: Wang Qilin [email protected]