Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.go: tiny tfix #874

Merged
merged 1 commit into from
Jun 14, 2017
Merged

config.go: tiny tfix #874

merged 1 commit into from
Jun 14, 2017

Conversation

Mashimiao
Copy link

Signed-off-by: Ma Shimiao [email protected]

@wking
Copy link
Contributor

wking commented Jun 7, 2017

The same "seperated" -> "separated" fix should jappen in config-windows.md, although that could be a follow-up PR.

config.go: tiny tfix
32f5ac6 
Signed-off-by: Ma Shimiao <[email protected]>
@crosbymichael
Copy link
Member

crosbymichael commented Jun 8, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

TomSweeneyRedHat
TomSweeneyRedHat reviewed Jun 8, 2017
View reviewed changes
Copy link

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hqhq
Copy link
Contributor

hqhq commented Jun 14, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@hqhq hqhq merged commit 9434694 into opencontainers:master Jun 14, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@dklyle dklyle dklyle approved these changes

@wking wking wking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mashimiao @wking @crosbymichael @hqhq @dklyle @TomSweeneyRedHat