schema: add clean to Makefile
#774
Conversation
Signed-off-by: zhouhao <[email protected]>
|
LGTM |
| @@ -16,3 +16,6 @@ validate: validate.go | |||
| go get -d ./... | |||
| go build ./validate.go | |||
|
|
|||
| clean: | |||
There was a problem hiding this comment.
I don't think that is necessary. make clean can be executed correctly.
There was a problem hiding this comment.
I don't think that is necessary. `make clean1 can be executed correctly.
So can make validate, with or without the .PHONY declaration. .PHONY keeps the target working even if someone creates a clean file. And while that is unlikely, I don't see why we shouldn't protect ourselves from it.
There was a problem hiding this comment.
If you do not add .PHONY, make validate can not be repeated, the following error occurs：
make: 'validate' is up to date.
so add the .PHONY.
There was a problem hiding this comment.
If you do not add
.PHONY,make validatecan not be repeated…
Fair. An example closer to your clean would be the the clean entry in the main Makefile.
|
LGTM |
Signed-off-by: zhouhao [email protected]