-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: modify Makefile #750
Conversation
Signed-off-by: zhouhao <[email protected]>
I don't see that it makes the help info incorrect. I'm two-ways about the default make target being |
@vbatts Not that incorrect, just not completely accurate.
To me it means "make needs an target, which can be fmt or validate", if we make validate default and target optional, I would like to see something like:
I'm also fine with changing the default target to be running the tests, just needs to fix help information as well. |
@hqhq oh oh, good catch. so yes, using square brackets there would be more accurate 😸 |
Signed-off-by: zhouhao <[email protected]>
@hqhq Thanks for your advice, updated, PTAL. |
Signed-off-by: zhouhao [email protected]