[ Config ] Simplify language for Windows #471
Conversation
Current language seems confusing:
> Windows, the volume name that is the target of the mount point. \?\Volume{GUID}\ (on Windows source is called target)
This PR proposes a simplification per conversation John Howard:
> On Windows, this MUST be a directory name.
Signed-off-by: Rob Dolin <[email protected]>
|
On Fri, May 27, 2016 at 09:47:12AM -0700, Rob Dolin (MSFT) wrote:
I have no idea what the old line was saying, so +1 on simplifying it Also, Travis sees some trailing whitespace at the end of your new |
|
Looks fine but needs rebase. |
|
LGTM Besides needing a rebase, this appears to be suffering from the same |
|
@RobDolinMS could you rebase and sign the commit? |
|
@RobDolinMS could you rebase? |
| @@ -46,7 +46,8 @@ The parameters are similar to the ones in [the Linux mount system call](http://m | |||
| * **`destination`** (string, required) Destination of mount point: path inside container. | |||
| For the Windows operating system, one mount destination MUST NOT be nested within another mount. (Ex: c:\\foo and c:\\foo\\bar). | |||
| * **`type`** (string, required) Linux, *filesystemtype* argument supported by the kernel are listed in */proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs", "reiserfs", "msdos", "proc", "nfs", "iso9660"). Windows: ntfs | |||
| * **`source`** (string, required) a device name, but can also be a directory name or a dummy. Windows, the volume name that is the target of the mount point. \\?\Volume\{GUID}\ (on Windows source is called target) | |||
| * **`source`** (string, required) a device name, but can also be a directory name or a dummy. | |||
There was a problem hiding this comment.
What does a dummy event mean?
|
@RobDolinMS when you have time please rebase your PRs and make sure your sign off is correct. Feel free to reopen when they have been updated. |
Current language seems confusing:
This PR proposes a simplification per conversation John Howard:
Signed-off-by: Rob Dolin [email protected]