Add dev symbolic links in runtime_linux.md #449
Conversation
Signed-off-by: Qiang Huang <[email protected]>
This is adapted from: https://github.com/opencontainers/runc/blob/master/libcontainer/SPEC.md Addresses: opencontainers/runc#760 Signed-off-by: Qiang Huang <[email protected]>
|
SGTM, though i'll defer to others |
|
|
||
| The runtime may pass additional file descriptors to the application to support features such as [socket activation](http://0pointer.de/blog/projects/socket-activated-containers.html). | ||
| After the container has `/proc` mounted, the following standard symlinks MUST be setup within `/dev/` for the io. |
There was a problem hiding this comment.
I'd recommend wording like the existing “MUST be made available” or “MUST … supply” instead of “MUST be setup”. Config authors and runtime callers should only care about the links being there, and shouldn't care about whether it was the runtime that set them up. And runtimes that bind-mount /dev (or similar) into the container may already have these links and not need to create them themselves. I'd also like to make the timing for these required objects explicit (see the third bullet here). And cross-links between these “paths the runtime must setup if missing” sections would be good too.
|
On Tue, May 24, 2016 at 01:13:45AM -0700, Qiang Huang wrote:
We probably want to cite proc(5) here, which has: Most Linux MAKEDEV scripts symbolically link /dev/fd to and: Most systems provide symbolic links /dev/stdin, /dev/stdout, and |
|
LGTM |
|
LGTM but needs rebase. |
|
LGTM |
Some fixes in runtime_linux.md, and added dev symbolic links.
It's adapted from:
https://github.com/opencontainers/runc/blob/master/libcontainer/SPEC.md
Addresses: opencontainers/runc#760
Signed-off-by: Qiang Huang [email protected]