-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appropriately mark optional fields as omitempty #283
Conversation
Signed-off-by: Jonathan Boulle <[email protected]>
LGTM |
Oh, one other item I forgot about that should be |
@arcnmx Thanks, @jonboulle Can you update for that? Thanks. |
done On Wed, Dec 30, 2015 at 2:16 AM, Qiang Huang [email protected]
|
@jonboulle You need to sign your commit. |
Signed-off-by: Jonathan Boulle <[email protected]>
Sigh. Done. On Thu, Dec 31, 2015 at 12:15 PM, Qiang Huang [email protected]
|
Thanks, still LGTM. |
LGTM |
Appropriately mark optional fields as omitempty
Signed-off-by: Jonathan Boulle [email protected]
per #282 (comment)