Update runtime.md #157
Merged
Update runtime.md #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clean the original PR #156.. |
|
LGTM |
| @@ -60,6 +61,7 @@ If a hook returns a non-zero exit code, then an error including the exit code an | |||
|
|
|||
| ### Post-stop | |||
| The post-stop hooks are called after the container process is stopped. Cleanup or debugging could be performed in such a hook. | |||
|
|
|||
There was a problem hiding this comment.
Probably no need to add this empty line.
|
lgtm |
|
@liangchenye rebase needed for merging |
Add an explicit explanation of the hooks order. Signed-off-by: Liang Chenye <[email protected]>
|
@vbatts done. |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Dec 11, 2015
Extend [1,2,3] to avoid:
hook 1: spawn ---------------> reaped
hook 2: spawn ----------------> reaped
hook 3: spawn -----> reaped
and explicitly require:
hook 1: spawn --> reaped
hook 2: spawn --> reaped
hook 3: spawn --> reaped
Folks who do want parallel execution are free to use a parallelizing
wrapper:
hook 1: spawn ---------------------------> reaped
child 1 -----> reaped
child 2 ---------> reaped
child 3 ---> reaped
Although that cuts both ways (with parallel hooks, folks could always
use a single hook with a serializing wrapper). Still, I'd guess most
current implementations are already taking the serialized approach, so
it makes bundle-author life easier if we are explicit about that.
[1]: opencontainers#20 (comment)
[2]: opencontainers#156
[3]: opencontainers#157
Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an explicit explanation of the hooks order.
Signed-off-by: Liang Chenye [email protected]