Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary: Provide a quick overview of important terms #107

Merged
merged 2 commits into from
Dec 24, 2015

Conversation

wking
Copy link
Contributor

@wking wking commented Aug 11, 2015

And link them to the more detailed specification.

This borrows from appc, which calls the launched process tree "the
app"
. I don't see a point to abbreviating it, so I've gone with
"application".

Subsection titles for the entries will be obnoxiously spacious, but
the other alternatives seem worse:

  • An HTML definition list (<dl>) would have nice default styling, but
    it's annoying to write raw HTML. And we would have needed
    something like:

      <dt name="bundle">Bundle</dt>
      <dd>
    
      A [directory structure](bundle.md) that is...
    
      </dd>
    

    to get Markdown-style links in the defintion itself.

  • A Markdown list (* …) would have reasonable default styling, but
    there's no Markdown syntax for adding anchors to the entries. And a
    glossary is much less useful if you can't link to a specific entry.

Spun off from #88.


## Bundle

A [directory structure](bundle.md) that is written ahead of time, distributed, and used to seed the runtime for creating [containers](#container) and launching [applications](#application).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

launching an application? A bundle only specifies launches a single application process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Tue, Aug 11, 2015 at 09:26:58PM -0700, Brandon Philips wrote:

+## Bundle
+
+A directory structure that is written ahead of time, distributed, and used to seed the runtime for creating containers and launching applications.

launching an application? A bundle only specifies launches a single
application process.

One application (which can result in a multi-process tree) per runtime
invocation yes. But you can use the same bundle to launch several
copies of the application.

And you can also have several config choices in a single bundle. My
proposed docs for this are in this subsection 1 of #76. That PR was
rejected for other reasons, but that particular subsection still
applies to the current spec and at least the runC implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is that a single bundle launches a single application. The bundle defines a single identity (bundle directory, cgroup hierarchy, etc) and a single lifecycle (hooks, etc).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Wed, Aug 12, 2015 at 09:42:27AM -0700, Brandon Philips wrote:

+## Bundle
+
+A directory structure that is written ahead of time, distributed, and used to seed the runtime for creating containers and launching applications.

The intention is that a single bundle launches a single
application. The bundle defines a single identity (bundle directory,
cgroup hierarchy, etc) and a single lifecycle (hooks, etc).

Do we explicitly set that “single application” limit somewhere? I
understand we have a default config location (config.json) for the
bundle 1, but I don't see why you couldn't store additional config
files in the bundle, and have optional runtime support for launching
from one of those additional configs 2. Allowing the default config
filename to be overridden at runtime seems both useful and easy to
implement, so I don't see an upside to requiring a
single-application-per-bundle limit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Wed, Aug 12, 2015 at 02:37:00PM -0700, W. Trevor King wrote:

Allowing the default config filename to be overridden at runtime
seems both useful and easy to implement…

For a concrete example, see 1, which supports both the IPFS gateway:

runc

and a shell for poking around:

runc config-sh.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Sat, Aug 29, 2015 at 01:40:07AM -0700, Lai Jiangshan wrote:

When the namespaces have been created, it implies that at least one
process has been started. (it is the runc init process for the
runc implementation for example)

RunC currently conflates the container creation and application
execution, but that's not required. For example, bocker:

  1. creates a network namespace, cgroups, and networking here 1,
  2. enters that container and executes the application 2, and
  3. deletes the container [3,4]

It doesn't split those into separate commands (since it's based on the
Docker UI), but you could certainly split them into separate
commands, and that seems like the most sane approach to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out.
But how to create other namespaces without starting any additional process?
Must be there some ways like network, but I can't find out any grace way currently.


I found a bad way (untested)

the creating process()
  unshare()
  mount --bind to save the namespace on some where.
  setns() back or exit.

the starting init process()
  setns() to the saved namespace.

So I think it is better to create namespaces when starting the container.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Sat, Aug 29, 2015 at 02:26:41AM -0700, Lai Jiangshan wrote:

But how to create other namespaces without starting any additional
process? Must be there some ways like network, but I can't find out
any grace way currently.

They may not all have a way ;). Any namespaces that turn out to
require a PID may require the runtime to store create-time
information, check that store when launching a new application, and
create any missing namespaces when launching that application. That
gives us consistent client semantics (e.g. you can still join an
existing user namespace by listing it's path in application.json 1).
And if/when the kernel gains the ability to create/destroy those
namespaces independently we can drop the associated runtime storage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so

Create

Creates the container: file system, namespaces, cgroups, capabilities.

is some kinds of misleading. Only the network namespace can be created
graciously before starting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Sat, Aug 29, 2015 at 10:25:27AM -0700, Lai Jiangshan wrote:

Create

Creates the container: file system, namespaces, cgroups, capabilities.

is some kinds of misleading. Only the network namespace can be
created graciously before starting.

That may be. But I think this is getting too far afield for this PR
(maybe shift it to 1?). I was only quoting that existing spec
(not suggesting we add that wording in this PR) to show that the
current spec seems to lean both ways (depending on which section
you're reading) about whether or not there will be multiple
applications in one container 2. And if we accept that the
singular/plural application question is currently up in the air, the
‘applications’ plural suggested by this PR isn't a major concession.

But that cuts both ways, so I guess I'll just change to singular here
and isolate the singular/plural lifecycle discussion in 1. Done in
the just pushed 5fc03cf→9db5fbe, which also rebases onto the current
master (not that there were any conflicts, but having a shorter
fork/merge delay makes for an easier-to-read history graph ;).

@wking
Copy link
Contributor Author

wking commented Aug 26, 2015

While commenting on #87, I realized that I don't understand what happens when a non-PID-namespaced process forks/execs a child that escapes its process tree. Is it still part of the “application” (I'm not sure)? Is that process something that gets terminated when we stop a container (I'm not sure, but this should probably be the same answer as for “application”)? Is it checkpointed/restored when we move a container (you could tie checkpointing into just the freezer cgroup)?

@wking
Copy link
Contributor Author

wking commented Sep 2, 2015

Rebased onto the current master to get #88 and reference both config.json and runtime.json. I also added a few links out to relevant sections of the spec.

In today's meeting, @vbatts was saying some of the wording here needed review, but after reading it over again I'm not sure what needs to change. I'm happy to make any changes required to get this landed.

@wking
Copy link
Contributor Author

wking commented Sep 25, 2015

I added a new commit with the UTF-8 JSON requirement (since that was the maintainer-recommended approach in #146.

@crosbymichael
Copy link
Member

I'm -1 on making this change now. This is adding new terms that don't exist, not being a glossary for existing things. There is no "Application". There are only containers and processes. Also the glossary has a little container/application infinite loop going on which is not helpful.

@wking
Copy link
Contributor Author

wking commented Oct 5, 2015

On Mon, Oct 05, 2015 at 11:01:47AM -0700, Michael Crosby wrote:

There is no "Application".

Dropped with b795e6fa57ba05, which also breaks the container ↔
application loop. Anything else that I need to change to get this
landed?

@wking
Copy link
Contributor Author

wking commented Oct 8, 2015

On Mon, Oct 05, 2015 at 11:09:12AM -0700, W. Trevor King wrote:

Mon, Oct 05, 2015 at 11:01:47AM -0700, Michael Crosby:

There is no "Application".

Dropped with b795e6fa57ba05

I missed a few with that update. Dropped the rest with a57ba05
6bddc28.


## Container

An environment for executing processes with configurable isolation and resource limitations (namespaces, resource limits, mounts, …).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just say "for example" instead of the parenthetical and ellipses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Tue, Dec 22, 2015 at 10:28:22PM -0800, Brandon Philips wrote:

+An environment for executing processes with configurable isolation and resource limitations (namespaces, resource limits, mounts, …).

just say "for example" instead of the parenthetical and ellipses?

In 6bddc280f9ec22 I've spun the parenthetical out into a new
sentence:

For example, namespaces, resource limits, and mounts are all part of
the container environment.

Does that address your concerns?

@philips
Copy link
Contributor

philips commented Dec 23, 2015

lgtm

And link them to the more detailed specification.

Subsection titles for the entries will be obnoxiously spacious, but
the other alternatives seem worse:

a. An HTML definition list (<dl>) would have nice default styling, but
   it's annoying to write raw HTML.  And we would have needed
   something like:

     <dt name="bundle">Bundle</dt>
     <dd>

     A [directory structure](bundle.md) that is...

     </dd>

   to get Markdown-style links in the defintion itself.

b. A Markdown list (* ...) would have reasonable default styling, but
   there's no Markdown syntax for adding anchors to the entries.  And
   a glossary is much less useful if you can't link to a specific
   entry.

Signed-off-by: W. Trevor King <[email protected]>
I wish there was a cleaner reference for what UTF-8 was.  But [1]
seems too glib, and I can't find a more targetted link than just
dropping folks into a Unicode chapter (which is what [1] does):

  The Unicode Standard, Version 6.0, §3.9 D92, §3.10 D95 (2011)

With the current v8.0 (2015-06-17), it's still §3.9 D92 and §3.10 D95.

I'd rather put this normative requirement in the configuration-spec
files, but maintainer consensus was to put it in the glossary [2,3].

[1]: https://en.wikipedia.org/wiki/UTF-8
[2]: opencontainers#146 (comment)
[3]: opencontainers#146 (comment)

Signed-off-by: W. Trevor King <[email protected]>
@hqhq
Copy link
Contributor

hqhq commented Dec 24, 2015

LGTM. Seems all terms are existed in specs, and I think it's good enough for now, merging, thanks.

hqhq added a commit that referenced this pull request Dec 24, 2015
glossary: Provide a quick overview of important terms
@hqhq hqhq merged commit 2fd5ad6 into opencontainers:master Dec 24, 2015
@wking wking deleted the glossary branch December 29, 2015 18:42
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Dec 30, 2015
So we have something to cite to avoid rehashing established decisions.
Provide some motivation and links to the backing discussion so folks
can re-open these if they have new information that wasn't covered in
the original decision.

Like the glossary (1873498, glossary: Provide a quick overview of
important terms, 2015-08-11, opencontainers#107), I've used subsection titles for
each entry to get link anchors.

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Dec 30, 2015
At the end of the list, to match its position in the README.  This
catches opencontainers#107 up with opencontainers#263, which I'd missed during one of the opencontainers#107
rebases.

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Jan 5, 2016
So we have something to cite to avoid rehashing established decisions.
Provide some motivation and links to the backing discussion so folks
can re-open these if they have new information that wasn't covered in
the original decision.

Like the glossary (1873498, glossary: Provide a quick overview of
important terms, 2015-08-11, opencontainers#107), I've used subsection titles for
each entry to get link anchors.

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this pull request Jun 22, 2016
Partially catch up with opencontainers/runtime-spec@7117ede7 (Expand
on the definition of our ops, 2015-10-13,
opencontainers/runtime-spec#225, v0.4.0).  The state example is
adapted from the current release [1], but we defer the actual
definition of that JSON to runtime-spec.  The UTF-8 requirement
extends [2] to the output state.

[1]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc1/runtime.md#state
[2]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc1/glossary.md#json
  I'd intended this restriction to cover all of our JSON [3], but I
  don't have a problem keeping the state restriction in this
  repository.
[3]: opencontainers/runtime-spec@0f9ec22b (glossary: Specify UTF-8 for all
     our JSON, 2015-09-25, opencontainers/runtime-spec#107).

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Jul 7, 2016
"Application process" was an early contender for this concept [1,2],
but there was pushback on that [3] and now "container process" is the
preferred term.

The initial "container process" phrasing landed in 15dee2e (runtime:
Add prestart/poststop hooks, 2015-08-03) around the same time as the
initial glossary work.

[1]: opencontainers#107 (comment)
[2]: opencontainers#107 (comment)
[3]: opencontainers#107 (comment)

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Jul 7, 2016
"Application process" was an early contender for this concept [1,2],
but there was pushback on that [3] and now "container process" is the
preferred term.

The initial "container process" phrasing landed in 15dee2e (runtime:
Add prestart/poststop hooks, 2015-08-03) around the same time as the
initial glossary work.

[1]: opencontainers#107 (comment)
[2]: opencontainers#107 (comment)
[3]: opencontainers#107 (comment)

Signed-off-by: W. Trevor King <[email protected]>
Mashimiao pushed a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
At the end of the list, to match its position in the README.  This
catches opencontainers#107 up with opencontainers#263, which I'd missed during one of the opencontainers#107
rebases.

Signed-off-by: W. Trevor King <[email protected]>
Mashimiao pushed a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
So we have something to cite to avoid rehashing established decisions.
Provide some motivation and links to the backing discussion so folks
can re-open these if they have new information that wasn't covered in
the original decision.

Like the glossary (1873498, glossary: Provide a quick overview of
important terms, 2015-08-11, opencontainers#107), I've used subsection titles for
each entry to get link anchors.

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this pull request Feb 9, 2017
Michael doesn't like "application" [1], and the runtime spec has
standardized around "container process".

[1]: opencontainers/runtime-spec#107 (comment)

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this pull request Feb 9, 2017
Michael doesn't like "application" [1], and the runtime spec has
standardized around "container process".

[1]: opencontainers/runtime-spec#107 (comment)

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants