-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: Unclear scope for platform section #725
Comments
@opencontainers/runtime-spec-maintainers any comments? |
Any thoughts? I think clarifying the intention here will help with language if we decide to “preview” Windows (and Solaris?) in 1.0. |
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this issue
May 24, 2017
Close: opencontainers#725 See discussion in opencontainers#830 , the full platform can be maintained in image-spec, but since we have platform-specific configurations in runtime-spec, I think it makes sence we keep a general simple definition for platform. Signed-off-by: Qiang Huang <[email protected]>
Merged
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this issue
May 24, 2017
Close: opencontainers#725 See discussion in opencontainers#830 , the full platform can be maintained in image-spec, but since we have platform-specific configurations in runtime-spec, I think it makes sence we keep a general simple definition for platform. Signed-off-by: Qiang Huang <[email protected]>
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this issue
May 24, 2017
Close: opencontainers#725 See discussion in opencontainers#830 , the full platform can be maintained in image-spec, but since we have platform-specific configurations in runtime-spec, I think it makes sence we keep a general simple definition for platform. Signed-off-by: Qiang Huang <[email protected]>
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this issue
Jun 15, 2017
Close: opencontainers#725 See discussion in opencontainers#830 and dev-weekly-meeting discussion in http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-06-14-21.03.log.txt We don't use this field in runc, and mostly only image-spec cares about this, we can assume tools know what specific platform this spec is built for. Signed-off-by: Qiang Huang <[email protected]>
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this issue
Jun 16, 2017
Close: opencontainers#725 See discussion in opencontainers#830 and dev-weekly-meeting discussion in http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-06-14-21.03.log.txt We don't use this field in runc, and mostly only image-spec cares about this, we can assume tools know what specific platform this spec is built for. Signed-off-by: Qiang Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In opencontainers/runtime-tools#347, @Mashimiao was reading the platform section as a restriction on
platform.os
. Something like:I read the
spec.md
section as a list of certification tracks:The spec should probably be updated to make it very clear which of these interpretations is intended.
With the restrictive approach (where
platform.os == "android"
was illegal), we should be using something like:With the permissive approach, we should update the spec section to make it clear that it does not restrict
platform.os
. And we probably want some notes about what happens in cases whereplatform.os
does not match any of the certification tracks, even if that is “these other configs are possible, but because they have no platform-specific configuration settings, we don't think they are useful enough to be worth a certification track”.The text was updated successfully, but these errors were encountered: