Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Unclear scope for platform section #725

Closed
wking opened this issue Mar 14, 2017 · 2 comments
Closed

spec: Unclear scope for platform section #725

wking opened this issue Mar 14, 2017 · 2 comments

Comments

@wking
Copy link
Contributor

wking commented Mar 14, 2017

In opencontainers/runtime-tools#347, @Mashimiao was reading the platform section as a restriction on platform.os. Something like:

platform.os may have permissive SHOULD language for valid values, but you can ignore that. Valid configs MUST be using one of these…

I read the spec.md section as a list of certification tracks:

Runtime-tools will have the following certification tracks: …. platform.os allows many other values (e.g. android), and valid configs MAY use those (with questionable usefulness), but there is currently no certification track for them.

The spec should probably be updated to make it very clear which of these interpretations is intended.

With the restrictive approach (where platform.os == "android" was illegal), we should be using something like:

* **`os`** (string, REQUIRED) specifies the operating system family of the container configuration's specified [`root`](#root) file system bundle.
  The runtime MUST generate an error if it does not support the specified **`os`**.
  Bundles MUST use `linux`, `solaris`, or `windows`.

With the permissive approach, we should update the spec section to make it clear that it does not restrict platform.os. And we probably want some notes about what happens in cases where platform.os does not match any of the certification tracks, even if that is “these other configs are possible, but because they have no platform-specific configuration settings, we don't think they are useful enough to be worth a certification track”.

@Mashimiao
Copy link

@opencontainers/runtime-spec-maintainers any comments?

@wking
Copy link
Contributor Author

wking commented May 18, 2017

Any thoughts? I think clarifying the intention here will help with language if we decide to “preview” Windows (and Solaris?) in 1.0.

hqhq added a commit to hqhq/runtime-spec that referenced this issue May 24, 2017
Close: opencontainers#725

See discussion in opencontainers#830 , the full platform can be maintained
in image-spec, but since we have platform-specific configurations
in runtime-spec, I think it makes sence we keep a general simple
definition for platform.

Signed-off-by: Qiang Huang <[email protected]>
hqhq added a commit to hqhq/runtime-spec that referenced this issue May 24, 2017
Close: opencontainers#725

See discussion in opencontainers#830 , the full platform can be maintained
in image-spec, but since we have platform-specific configurations
in runtime-spec, I think it makes sence we keep a general simple
definition for platform.

Signed-off-by: Qiang Huang <[email protected]>
hqhq added a commit to hqhq/runtime-spec that referenced this issue May 24, 2017
Close: opencontainers#725

See discussion in opencontainers#830 , the full platform can be maintained
in image-spec, but since we have platform-specific configurations
in runtime-spec, I think it makes sence we keep a general simple
definition for platform.

Signed-off-by: Qiang Huang <[email protected]>
hqhq added a commit to hqhq/runtime-spec that referenced this issue Jun 15, 2017
Close: opencontainers#725

See discussion in opencontainers#830 and dev-weekly-meeting discussion
in http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-06-14-21.03.log.txt

We don't use this field in runc, and mostly only
image-spec cares about this, we can assume tools know
what specific platform this spec is built for.

Signed-off-by: Qiang Huang <[email protected]>
hqhq added a commit to hqhq/runtime-spec that referenced this issue Jun 16, 2017
Close: opencontainers#725

See discussion in opencontainers#830 and dev-weekly-meeting discussion
in http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-06-14-21.03.log.txt

We don't use this field in runc, and mostly only
image-spec cares about this, we can assume tools know
what specific platform this spec is built for.

Signed-off-by: Qiang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants