Setting cgroup resources #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Usage: "set cgroup resources", | ||
| Flags: []cli.Flag{ | ||
| cli.StringFlag{ | ||
| Name: "config-file, c", |
There was a problem hiding this comment.
This shouldn't require the path to config.json then. We probably want the bundlePath from the other PR.
Signed-off-by: rajasec <[email protected]> Adding bundle path Signed-off-by: Rajasekaran <[email protected]> Updating README file Signed-off-by: rajasec <[email protected]>
|
@mrunalp |
|
@rajasec Actually Maybe we should start discussing https://github.com/opencontainers/specs/blob/master/ROADMAP.md#live-container-updates , have a conclusion about what can be updated, and we only take care of these fields from config. |
|
I think we should revisit this later once we have a plan in the spec. Closing for now. |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Fix the build by getting rid of go get for vet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the container interface set to set the cgroup resources when container is running
Usage:
runc set
This will apply the new values to running container as per the runtime.json
Signed-off-by: rajasec [email protected]