Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc checkpoint: destroy only on success #3655

Merged
merged 1 commit into from
Nov 22, 2022
Merged

runc checkpoint: destroy only on success #3655

merged 1 commit into from
Nov 22, 2022

Commits on Nov 3, 2022

  1. runc checkpoint: destroy only on success 

    If checkpointing has failed, the container is kept running. We do not
want to, and we can't remove it in such case.

Do not try to remove the container if there's an error from
checkpointing.

This avoids an unclear error message from destroy() saying "container
still running" or "container paused".

While at it, avoid using defer since it does not make a lot of sense
here.

Fixes: opencontainers#3577
Reported-by: gosoon <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    783f9ff View commit details
    Browse the repository at this point in the history