-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for seccomp actions ActKillThread and ActKillProcess #3204
Add support for seccomp actions ActKillThread and ActKillProcess #3204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would structure this the other way around (drop unnecessary defines first, add ActKill{Thread,Process} next) -- will be cleaner this way, and less git history to dig through.
But it's a teeny tiny change and thus it's fine with it as it is.
LGTM
These are just boilerplate and are only really useful for the two actions which require us to set a default errno/aux value (ActErrno and ActTrace). Signed-off-by: Aleksa Sarai <[email protected]>
Two new seccomp actions have been added to the libseccomp-golang dependency, which can be now supported by runc, too. ActKillThread kills the thread that violated the rule. It is the same as ActKill. All other threads from the same thread group will continue to execute. ActKillProcess kills the process that violated the rule. All threads in the thread group are also terminated. This action is only usable when libseccomp API level 3 or higher is supported. Signed-off-by: Sascha Grunert <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
Ah you're quite right @kolyshkin, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Carry of #2564.
Two new seccomp actions have been added to the libseccomp-golang
dependency, which can be now supported by runc, too.
ActKillThread kills the thread that violated the rule. It is the same as
ActKill. All other threads from the same thread group will continue to
execute.
ActKillProcess kills the process that violated the rule. All threads in
the thread group are also terminated. This action is only usable when
libseccomp API level 3 or higher is supported.
Signed-off-by: Sascha Grunert [email protected]
Signed-off-by: Aleksa Sarai [email protected]