Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various linting issues #2974

Merged
merged 9 commits into from
Jun 2, 2021
Merged

Fix various linting issues #2974

merged 9 commits into from
Jun 2, 2021

Commits on Jun 2, 2021

  1. libcontainer/user: remove unused ErrUnsupported 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    02fb18e View commit details
    Browse the repository at this point in the history

  2. libcontainer/apparmor: split api (exported) from implementation 

    This prevents having to maintain GoDoc for the stub implementations,
and makes sure that the "stub" implementations have the same signature
as the "non-stub" versions.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    c064304 View commit details
    Browse the repository at this point in the history

  3. libcontainer/configs: add / fix godoc (golint) 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e204d6a View commit details
    Browse the repository at this point in the history

  4. libcontainer/user: fix capitalization (golint) 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    81fc5c8 View commit details
    Browse the repository at this point in the history

  5. libcontainer/nsenter: fix captalization (golint) 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    340fdd9 View commit details
    Browse the repository at this point in the history

  6. libcontainer/devices: fix godoc (golint) 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    9be156c View commit details
    Browse the repository at this point in the history

  7. libcontainer/system: fix godoc (golint) 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    c2416fb View commit details
    Browse the repository at this point in the history

  8. libcontainer/cgroups/devices: if block ends with a return statement 

        libcontainer/cgroups/devices/devices_emulator.go:261:9: `if` block ends with a `return` statement, so drop this `else` and outdent its block (golint)
    	} else {
    	       ^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1fb56f9 View commit details
    Browse the repository at this point in the history

  9. libcontainer/keys: var should be sessKeyID/ringID (golint) 

        libcontainer/keys/keyctl.go:17:2: var `sessKeyId` should be `sessKeyID` (golint)
        sessKeyId, err := unix.KeyctlJoinSessionKeyring(name)
        ^

    libcontainer/keys/keyctl.go:27:21: func parameter `ringId` should be `ringID` (golint)
    func ModKeyringPerm(ringId KeySerial, mask, setbits uint32) error {
                        ^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    3e1bcb1 View commit details
    Browse the repository at this point in the history