Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freezer: add delay after freeze #2941

Merged

Commits on May 6, 2021

  1. freezer: add delay after freeze

    I hate to keep adding those kludges, but lately TestFreeze (and
    TestSystemdFreeze) from libcontainer/integration fails a lot. The
    failure comes and goes, and is probably this is caused by a slow host
    allocated for the test, and a slow VM on top of it.
    
    To remediate, add a small sleep on every 25th iteration in between
    asking the kernel to freeze and checking its status.
    
    In the worst case scenario (failure to freeze), this adds about 0.4 ms
    (40 x 10 us) to the duration of the call.
    
    It is hard to measure how this affects CI as GHA plays a roulette when
    allocating a node to run the test on, but it seems to help. With
    additional debug info, I saw somewhat frequent "frozen after 24 retries"
    or "frozen after 49 retries", meaning it succeeded right after the added
    sleep.
    
    While at it, rewrite/improve the comments.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed May 6, 2021
    Configuration menu
    Copy the full SHA
    524abc5 View commit details
    Browse the repository at this point in the history